fix: Expose Uplift theme #1640
Merged
fix: Expose Uplift theme #1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to be able to have two variations of the Uplift theme: a standard and a "ghost" version. As such we can't simply overwrite properties of the theme as shown [here](https://polaris-viz.shopify.com/iframe.html?viewMode=docs&id=shared-themes-customizing--page#titleAnchor-81). Instead we need to define multiple themes as shown [here](https://polaris-viz.shopify.com/iframe.html?viewMode=docs&id=shared-themes-customizing--page#titleAnchor-86). To do this with Uplift as a base however, the theme needs to be exposed, which it currently isn't. In theory this can be retrieved via the `@shopify/polaris-viz-core`, but the same is true for the other themes and that would mean that dependency becomes a direct dependency of the project, rather than through `@shopify/polaris-viz`. Instead, it's proposed here that we just expose the Uplift theme in a manner similar to the others.
size-limit report 📦
|
envex
approved these changes
Mar 19, 2024
|
@envex thanks for the review! How are the releases for this package done please? There is some blocking feedback on a project about styling issues related to this, so having a version available with this soon would be appreciated. |
|
@maael I'll cut a release for you right now. |
|
@envex 🙌 fantastic, thank you very much. |
|
@maael |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
We need to be able to have two variations of the Uplift theme: a standard and a "ghost" version.
As such we can't simply overwrite properties of the theme as shown here.
Instead we need to define multiple themes as shown here.
To do this with Uplift as a base however, the theme needs to be exposed, which it currently isn't.
In theory this can be retrieved via the
@shopify/polaris-viz-core, but the same is true for the other themes and that would mean that dependency becomes a direct dependency of the project, rather than through@shopify/polaris-viz.Instead, it's proposed here that we just expose the Uplift theme in a manner similar to the others.
Does this close any currently open issues?
Related:
What do the changes look like?
There are no visual changes, this is a package API change.
Storybook link
There are no visual changes, this is a package API change.
Before merging
Check your changes on a variety of browsers and devices.
Update the Changelog's Unreleased section with your changes.
Update relevant documentation, tests, and Storybook.
Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package